[Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

Lenka Doudova ldoudova at redhat.com
Mon Nov 23 09:43:10 UTC 2015


NACK - there's a "typo" in ..../tracker/user_plugin.py, line 17-18:

def get_user_dn(cn):

     return DN(('cn', cn), api.env.container_user, api.env.basedn)


should be

def get_user_dn(uid):

     return DN(('uid', uid), api.env.container_user, api.env.basedn)


Some tests may fail because of that.
Lenka


On 11/20/2015 08:54 PM, Aleš Mareček wrote:
> Looks good. ACK.
>
> ----- Original Message -----
>> From: "Milan Kubík" <mkubik at redhat.com>
>> To: "freeipa-devel" <freeipa-devel at redhat.com>
>> Cc: "Filip Skola" <fskola at redhat.com>, "Ales Marecek" <amarecek at redhat.com>
>> Sent: Friday, November 20, 2015 3:44:30 PM
>> Subject: [patch 0025] Separated Tracker implementations into standalone package
>>
>> Fixes https://fedorahosted.org/freeipa/ticket/5467
>> Patches attached.
>>
>> --
>> Milan Kubik
>>
>>




More information about the Freeipa-devel mailing list