[Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

Milan Kubík mkubik at redhat.com
Fri Nov 27 14:31:43 UTC 2015


On 11/23/2015 10:43 AM, Lenka Doudova wrote:
> NACK - there's a "typo" in ..../tracker/user_plugin.py, line 17-18:
>
> def get_user_dn(cn):
>
>     return DN(('cn', cn), api.env.container_user, api.env.basedn)
>
>
> should be
>
> def get_user_dn(uid):
>
>     return DN(('uid', uid), api.env.container_user, api.env.basedn)
>
>
> Some tests may fail because of that.
> Lenka
>
>
> On 11/20/2015 08:54 PM, Aleš Mareček wrote:
>> Looks good. ACK.
>>
>> ----- Original Message -----
>>> From: "Milan Kubík" <mkubik at redhat.com>
>>> To: "freeipa-devel" <freeipa-devel at redhat.com>
>>> Cc: "Filip Skola" <fskola at redhat.com>, "Ales Marecek" 
>>> <amarecek at redhat.com>
>>> Sent: Friday, November 20, 2015 3:44:30 PM
>>> Subject: [patch 0025] Separated Tracker implementations into 
>>> standalone package
>>>
>>> Fixes https://fedorahosted.org/freeipa/ticket/5467
>>> Patches attached.
>>>
>>> -- 
>>> Milan Kubik
>>>
>>>
>
Fixed the function and moved it into different module.
Updated patches attached.

-- 
Milan Kubik

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0025-2-Separated-Tracker-implementations-into-standalone-pa.patch
Type: text/x-patch
Size: 111976 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151127/3f66479b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0025-2-Separated-Tracker-implementations-into-standalone-pa.patch
Type: text/x-patch
Size: 111995 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151127/3f66479b/attachment-0001.bin>


More information about the Freeipa-devel mailing list