[Freeipa-devel] [PATCH] Proper fix for ticket 5306

[Martin Basti]

On 10/02/2015 04:14 PM, Milan Kubík wrote:
> On 10/02/2015 04:11 PM, Martin Basti wrote:
>>
>>
>> On 10/01/2015 02:48 PM, Martin Basti wrote:
>>>
>>>
>>> On 10/01/2015 02:43 PM, Oleg Fayans wrote:
>>>> Hi Martin,
>>>>
>>>> On 10/01/2015 11:18 AM, Martin Basti wrote:
>>>>>
>>>>>
>>>>> On 09/30/2015 01:24 PM, Martin Basti wrote:
>>>>>>
>>>>>>
>>>>>> On 09/30/2015 12:19 PM, Oleg Fayans wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 09/30/2015 11:46 AM, Petr Spacek wrote:
>>>>>>>> On 29.9.2015 09:12, Oleg Fayans wrote:
>>>>>>>>> +def prepare_reverse_zone(host, ip):
>>>>>>>>> +    zone = get_reverse_zone_default(ip)
>>>>>>>>> +    host.run_command(["ipa",
>>>>>>>>> +                      "dnszone-add",
>>>>>>>>> +                      zone,
>>>>>>>>> +                      "--name-from-ip=%s" % ip], 
>>>>>>>>> raiseonerr=False)
>>>>>>>>
>>>>>>>> There is probably no point in specifying --name-from-ip because 
>>>>>>>> you
>>>>>>>> did that
>>>>>>>> already by calling get_reverse_zone_default(ip).
>>>>>>>
>>>>>>> Agree. Fixed
>>>>>>>
>>>>>>>>
>>>>>>>> Anyway, I'm not sure that this
>>>>>>>>> + prepare_reverse_zone(master, replica.ip)
>>>>>>>> will not break if the reverse zone already exists (think about 
>>>>>>>> case
>>>>>>>> where two
>>>>>>>> or more replicas are in the same subnet).
>>>>>>>
>>>>>>> That's why I am using the raiseonerr=False here.
>>>>>>>
>>>>>>>>
>>>>>>>> I did not test the code, I simply do not have time for it right 
>>>>>>>> now.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>  LGTM, I will test it soon, but it needs rebase for ipa-4-2 branch
>>>>>>
>>>>>>
>>>>> ACK, please send rebased version for ipa-4-2
>>>>
>>>> Here it is
>>>>
>>> Pushed to ipa-4-2: c898c968d3979a0d8c2fe0db8e125dfc2268eba0
>>> Pushed to master: 03d696f224642c1c4c4f1a434fecefd1c6270e37
>>>
>>
>> In rebased patch for ipa-4-2 you removed import for function and I 
>> didn't noticed that.
>> This breaks builds of ipa-4-2.
>>
>> Patch that fix this attached.
>>
>>
>>
> ACK
>
> -- 
> Milan Kubik
Pushed to ipa-4-2: e7a33b71256dbda37308c4fd0ac5394472c753f7
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151002/b149272a/attachment.htm>