[Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

[Martin Basti]

On 22.10.2015 15:23, Martin Basti wrote:
>
> On 22.10.2015 14:13, Oleg Fayans wrote:
>>
>>
>>
>
> Hello,
>
> thank you for the patch.
>
> 1)
> please remove the added empty lines, they are unrelated to this ticket
>
> 2)
> -def install_master(host, setup_dns=True, setup_kra=False):
> +def install_master(host, setup_dns=True, setup_kra=False, domainlevel=1):
>
> I suggest to use default domainlevel=None, which will use the default 
> domain level (specified in build)
>
> 3)
> +    domain_level = domainlevel(master)
> I do not think that this meets expectations.
>
> We have to test, both domain level 0 and 1 for IPA 4.3, respectively 
> new IPA must support all older domain levels, domain level is 
> independent on IPA version, only admin can raise it up.
>
> So you have to find out way how to pass the domain level for which 
> test will be running, we were talking about using config files, but 
> feel free to find something new and better
>
> 4)
> Did you resolve the pytest fixtures which specifies which tests can be 
> run under which domain level?
>
> 5)
> +                        '--ip-address', client.ip,
>
> why this change to client install?
>
> Martin^2
>
>
6)
************* Module ipatests.test_integration.tasks
ipatests/test_integration/tasks.py:85: [E1123(unexpected-keyword-arg), 
allow_sync_ptr] Unexpected keyword argument 'raiseonerr' in function call)


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151022/8d46f9b3/attachment.htm>