[Freeipa-devel] [PATCH 0011] Replica promotion related changes in integration tests

[Oleg Fayans]

Hi Martin,

Here comes the updated version.

On 10/22/2015 05:38 PM, Martin Basti wrote:
>
>
> On 22.10.2015 15:23, Martin Basti wrote:
>>
>> On 22.10.2015 14:13, Oleg Fayans wrote:
>>>
>>>
>>>
>>
>> Hello,
>>
>> thank you for the patch.
>>
>> 1)
>> please remove the added empty lines, they are unrelated to this ticket

done

>>
>> 2)
>> -def install_master(host, setup_dns=True, setup_kra=False):
>> +def install_master(host, setup_dns=True, setup_kra=False, domainlevel=1):
>>
>> I suggest to use default domainlevel=None, which will use the default
>> domain level (specified in build)

done

>>
>> 3)
>> +    domain_level = domainlevel(master)
>> I do not think that this meets expectations.
>>
>> We have to test, both domain level 0 and 1 for IPA 4.3, respectively
>> new IPA must support all older domain levels, domain level is
>> independent on IPA version, only admin can raise it up.
>>
>> So you have to find out way how to pass the domain level for which
>> test will be running, we were talking about using config files, but
>> feel free to find something new and better

Fixed. Now, we declare domain level in config.yaml with the directive 
domain_level

>>
>> 4)
>> Did you resolve the pytest fixtures which specifies which tests can be
>> run under which domain level?

In fact, we do not seem to have any tests yet that would require it. All 
the existing tests just use install_replica
  method, no matter how is it done.

>>
>> 5)
>> +                        '--ip-address', client.ip,
>>
>> why this change to client install?

Right, it found to be unnecessary.

>>
>> Martin^2
>>
>>
> 6)
> ************* Module ipatests.test_integration.tasks
> ipatests/test_integration/tasks.py:85: [E1123(unexpected-keyword-arg),
> allow_sync_ptr] Unexpected keyword argument 'raiseonerr' in function call)

Fixed

>
>

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .freeipa-ofayans-0011.1-replica-promotion-changes-in-tests.patch.swp
Type: application/octet-stream
Size: 16384 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/2c7bf475/attachment.obj>