[Freeipa-devel] [PATCH 0329] Tests: fix user tracker

[Martin Basti]

On 26.10.2015 09:01, Lenka Doudova wrote:
>
>
> On 10/21/2015 06:53 AM, Lenka Doudova wrote:
>>
>>
>> On 10/20/2015 06:21 PM, Martin Basti wrote:
>>>
>>>
>>> On 20.10.2015 15:53, Martin Basti wrote:
>>>>
>>>>
>>>> On 19.10.2015 14:16, Martin Basti wrote:
>>>>>
>>>>>
>>>>> On 19.10.2015 12:30, Martin Basti wrote:
>>>>>> Attribute nsaccountlock has not been processed correctly
>>>>>>
>>>>>> Patch attached.
>>>>>>
>>>>>>
>>>>>
>>>>> Self-NACK, more fixes required
>>>>>
>>>>>
>>>>>
>>>> Updated patch attached, but it still needs to improve because tests 
>>>> in my patch 331 are still failing.
>>>>
>>>
>>> Eternal self-NACK for this patch
>>>
>>> I'm not able to fix UserTracker, I need help from somebody with 
>>> higher view of how this tracker is supposed to work.
>>> Follow my patch 0331
>>
>> Hi, I'll take a look at it today.
>> Lenka
>>
>>
> Hi,
>
> I fixed the trackers and tests, rebased patch attached.
> Lenka
>
>

Thank you,

1)
************* Module ipatests.test_xmlrpc.test_stageuser_plugin
ipatests/test_xmlrpc/test_stageuser_plugin.py:938: 
[E0102(function-redefined), TestMultipleManagers] class already defined 
line 913)

2)
Because the patch contains tests too, I suggest to rename patch to 
Multiple manager per user tests.
Also you should change commiter of patch to you.

Martin^2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151026/bc6be872/attachment.htm>