[Freeipa-devel] [PATCH 0060-0061] DNSSEC improvements in uninstaller

[Petr Spacek]

On 30.10.2015 10:55, Martin Basti wrote:
> 
> 
> On 30.10.2015 10:41, Petr Spacek wrote:
>> Hello,
>>
>> DNSSEC: on uninstall, do not restore OpenDNSSEC kasp.db if backup failed
>> DNSSEC: improve log messages in uninstaller
>>
>> This is suitable for ipa-4-2 branch and newer.
>>
> NACK
> 
> Please extract the list from for cycle to separate variable and do extend with
> that variable.
> 
> Also this code doesnt work, I tried simillar in python and I got:
> 
> In [1]: t=[1]
> 
> In [2]: for f in [10, 20, 30].extend(t):
>    ...:     print f
>    ...:
> ---------------------------------------------------------------------------
> TypeError                                 Traceback (most recent call last)
> <ipython-input-2-bb6c0d6748ef> in <module>()
> ----> 1 for f in [10, 20, 30].extend(t):
>       2     print f
>       3
> 
> TypeError: 'NoneType' object is not iterable

Thank you for catching this. I believed to lint and that was a bad idea!

Push only to master is fine with me, I'm not willing to go though more
bureaucracy for this small change.

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0061-2-DNSSEC-on-uninstall-do-not-restore-OpenDNSSEC-kasp.d.patch
Type: text/x-patch
Size: 2192 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151030/8a169994/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0060-DNSSEC-improve-log-messages-in-uninstaller.patch
Type: text/x-patch
Size: 1225 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151030/8a169994/attachment-0001.bin>