[Freeipa-devel] [PATCH 0060-0061] DNSSEC improvements in uninstaller

[Martin Basti]

On 30.10.2015 11:16, Petr Spacek wrote:
> On 30.10.2015 10:55, Martin Basti wrote:
>>
>> On 30.10.2015 10:41, Petr Spacek wrote:
>>> Hello,
>>>
>>> DNSSEC: on uninstall, do not restore OpenDNSSEC kasp.db if backup failed
>>> DNSSEC: improve log messages in uninstaller
>>>
>>> This is suitable for ipa-4-2 branch and newer.
>>>
>> NACK
>>
>> Please extract the list from for cycle to separate variable and do extend with
>> that variable.
>>
>> Also this code doesnt work, I tried simillar in python and I got:
>>
>> In [1]: t=[1]
>>
>> In [2]: for f in [10, 20, 30].extend(t):
>>     ...:     print f
>>     ...:
>> ---------------------------------------------------------------------------
>> TypeError                                 Traceback (most recent call last)
>> <ipython-input-2-bb6c0d6748ef> in <module>()
>> ----> 1 for f in [10, 20, 30].extend(t):
>>        2     print f
>>        3
>>
>> TypeError: 'NoneType' object is not iterable
> Thank you for catching this. I believed to lint and that was a bad idea!
>
> Push only to master is fine with me, I'm not willing to go though more
> bureaucracy for this small change.
>
ACK
Pushed to master: 6f855dcc5cbd4a316ae03cdf0e2cc7e8c21bec88