[Freeipa-devel] [PATCHES 481-486] Metaclass and str modernization

[Jan Cholasta]

On 3.9.2015 19:23, Petr Viktorin wrote:
> On 09/01/2015 04:47 PM, Jan Cholasta wrote:
>> Hi,
>>
>> the attached patches add some more modernization to our code.
>>
>> Honza
>
> 481: ACK
> 482: ACK
> 483: ACK
>
> You can push these without waiting on the later ones.

Pushed to master: cc53526fd21d3faa7b90cd873713279c3ce049f5

>
>
> 484:
> To avoid merge conflicts later, perhaps it would be better to have
>
>      if six.PY3:
>          unicode = str
>
> at the start of each affected file, instead of scattering changes in the
> files?
> (I can prepare the patch if you agree)

(Be my guest)

>
>
> 485:
> six.binary_type is named "bytes" since Python 2.6. I think it would be
> better to use that, to avoid another change when py2 is dropped.
> (I can prepare the patch here, too)

(OK)

>
>
> 486: ACK
>


-- 
Jan Cholasta