[Freeipa-devel] [PATCHES 481-486] Metaclass and str modernization

[Petr Viktorin]

On 09/07/2015 08:02 AM, Jan Cholasta wrote:
> On 3.9.2015 19:23, Petr Viktorin wrote:
>> On 09/01/2015 04:47 PM, Jan Cholasta wrote:
>>> Hi,
>>>
>>> the attached patches add some more modernization to our code.
[...]
>> 484:
>> To avoid merge conflicts later, perhaps it would be better to have
>>
>>      if six.PY3:
>>          unicode = str
>>
>> at the start of each affected file, instead of scattering changes in the
>> files?
>> (I can prepare the patch if you agree)
> 
> (Be my guest)
> 
>>
>>
>> 485:
>> six.binary_type is named "bytes" since Python 2.6. I think it would be
>> better to use that, to avoid another change when py2 is dropped.
>> (I can prepare the patch here, too)
> 
> (OK)
> 
>>
>>
>> 486: ACK

Here are the two patches updated to use "unicode" and "bytes".


-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-484.2-Alias-unicode-to-str-under-Python-3.patch
Type: text/x-patch
Size: 58517 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150911/b6193a8f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-485.2-Use-bytes-instead-of-str-where-appropriate.patch
Type: text/x-patch
Size: 11213 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150911/b6193a8f/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-486.2-Use-byte-literals-where-appropriate.patch
Type: text/x-patch
Size: 11559 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150911/b6193a8f/attachment-0002.bin>