[Freeipa-devel] [PATCHES 481-486] Metaclass and str modernization

[Jan Cholasta]

On 11.9.2015 15:24, Petr Viktorin wrote:
> On 09/07/2015 08:02 AM, Jan Cholasta wrote:
>> On 3.9.2015 19:23, Petr Viktorin wrote:
>>> On 09/01/2015 04:47 PM, Jan Cholasta wrote:
>>>> Hi,
>>>>
>>>> the attached patches add some more modernization to our code.
> [...]
>>> 484:
>>> To avoid merge conflicts later, perhaps it would be better to have
>>>
>>>       if six.PY3:
>>>           unicode = str
>>>
>>> at the start of each affected file, instead of scattering changes in the
>>> files?
>>> (I can prepare the patch if you agree)
>>
>> (Be my guest)
>>
>>>
>>>
>>> 485:
>>> six.binary_type is named "bytes" since Python 2.6. I think it would be
>>> better to use that, to avoid another change when py2 is dropped.
>>> (I can prepare the patch here, too)
>>
>> (OK)
>>
>>>
>>>
>>> 486: ACK
>
> Here are the two patches updated to use "unicode" and "bytes".

Thanks, ACK.

Pushed to master: 33aba6f35e43b5febf1751de4cef2863749f93e7

-- 
Jan Cholasta