[Freeipa-devel] Linking tickets in the commit messages

[Lenka Doudova]

Hi,

though I'm not a fellow developer, I'd like to point out that the habit 
you mentioned (putting a link into commit message) is indeed documented 
on wiki [1].
It's just on a spot where it's not that much visible.

Sorry if I misunderstood the point of your email.

Lenka

[1] http://www.freeipa.org/page/Contribute/Patch_Format

On 09/17/2015 01:47 PM, Tomas Babej wrote:
> Hi fellow developers,
>
> more or less we tend to stick to the tradition of linking Trac tickets
> to the commit messages of the patches we send to the list.
>
> However, every now and then, a patch lands on the list, which is either
> linked to a BZ or does not contain any link at all. Admittedly, I am
> also guilty of this mishap. This poses certain problems, as we're trying
> to automate the bookkeeping and pushing-related processes with ipatool [1].
>
> Nevertheless, this useful habit is not formally agreed upon by
> developers nor documented in our wiki [2]. I'd suggest we add it there,
> if we come to such consensus.
>
> This would mean:
> * Patches fixing an issue described only in BZ (rare issue) would need
> to create a Trac ticket referencing the BZ
> * Patches fixing an issue not tracked in Trac nor BZ would need to file
> a ticket in Trac and reference it
>
> Thoughts?
>
> [1] https://github.com/freeipa/freeipa-tools/blob/master/ipatool
> [2] http://www.freeipa.org/page/Contribute/Code
>