[Freeipa-devel] [PATCH 0086] Migrate OTP import script to python-cryptography

[Martin Babinsky]

On 09/25/2015 04:53 PM, Nathaniel McCallum wrote:
> On Mon, 2015-08-31 at 11:08 -0400, Nathaniel McCallum wrote:
>> https://fedorahosted.org/freeipa/ticket/5192
>> --
>> Manage your subscription for the Freeipa-devel mailing list:
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>
> Attached patch rebases the previous patch for master.
>
> Nathaniel
>
>
>
Hi Nathaniel,

pylint is not happy with your patches:

"""
************* Module ipaserver.install.ipa_otptoken_import
ipaserver/install/ipa_otptoken_import.py:189: 
[E1120(no-value-for-parameter), PBKDF2KeyDerivation.__init__] No value 
for argument 'backend' in constructor call)
ipaserver/install/ipa_otptoken_import.py:235: 
[E1120(no-value-for-parameter), XMLDecryptor.__call__] No value for 
argument 'backend' in constructor call)
"""

This is probably the reason for 2 of the otptoken_import tests to fail 
with TypeError, see http://fpaste.org/271526/31985721/

-- 
Martin^3 Babinsky