[Freeipa-devel] [PATCH 0086] Migrate OTP import script to python-cryptography

Nathaniel McCallum npmccallum at redhat.com
Fri Sep 25 17:05:11 UTC 2015


On Fri, 2015-09-25 at 18:29 +0200, Martin Babinsky wrote:
> On 09/25/2015 04:53 PM, Nathaniel McCallum wrote:
> > On Mon, 2015-08-31 at 11:08 -0400, Nathaniel McCallum wrote:
> > > https://fedorahosted.org/freeipa/ticket/5192
> > > --
> > > Manage your subscription for the Freeipa-devel mailing list:
> > > https://www.redhat.com/mailman/listinfo/freeipa-devel
> > > Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Cod
> > > e
> > 
> > Attached patch rebases the previous patch for master.
> > 
> > Nathaniel
> > 
> > 
> > 
> Hi Nathaniel,
> 
> pylint is not happy with your patches:
> 
> """
> ************* Module ipaserver.install.ipa_otptoken_import
> ipaserver/install/ipa_otptoken_import.py:189: 
> [E1120(no-value-for-parameter), PBKDF2KeyDerivation.__init__] No
> value 
> for argument 'backend' in constructor call)
> ipaserver/install/ipa_otptoken_import.py:235: 
> [E1120(no-value-for-parameter), XMLDecryptor.__call__] No value for 
> argument 'backend' in constructor call)
> """
> 
> This is probably the reason for 2 of the otptoken_import tests to
> fail 
> with TypeError, see http://fpaste.org/271526/31985721/

Fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-npmccallum-0086.2-Migrate-OTP-import-script-to-python-cryptography.patch
Type: text/x-patch
Size: 14201 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150925/53817c5f/attachment.bin>


More information about the Freeipa-devel mailing list