[Freeipa-devel] [TEST][Patch 0022] small refactoring in integration tests due to BZ 1303095

Oleg Fayans ofayans at redhat.com
Thu Feb 4 07:49:51 UTC 2016


Hi Petr,

On 02/03/2016 02:19 PM, Petr Spacek wrote:
> On 3.2.2016 10:22, Oleg Fayans wrote:
>> Guys, can anyone take a look at this?
> 
> The commit message does not explain why you are setting search path.

Fixed.

> 
> I have to say that I do not like touching resolv.conf, as stated many times
> earlier. Why the test has to reconfigure the host and cannot use values
> provided by the provisioning system?

This patch exactly removes this messing around with nameservers in
resolv.conf
It introduces the possibility to put ipa domain in the search directive
of resolv.conf so that we could test service autodiscovery during client
installation.

> 

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0022.1-Moved-NM-configuration-calls-to-the-IntegrationTest.patch
Type: text/x-patch
Size: 3592 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160204/735af2ae/attachment.bin>


More information about the Freeipa-devel mailing list