[Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

[Milan Kubík]

On 02/24/2016 07:05 PM, Martin Basti wrote:
>
>
> On 24.02.2016 08:34, Milan Kubík wrote:
>> On 02/18/2016 03:52 PM, Milan Kubík wrote:
>>> On 02/15/2016 04:59 PM, Milan Kubík wrote:
>>>> Patch attached. Applies on ipa-4-3 as well.
>>>>
>>>>
>>>>
>>> Updated version of patch fixes test_old_permission_plugin as well.
>>>
>>> -- 
>>> Milan Kubik
>>>
>>>
>> Review bump.
>>
>> -- 
>> Milan Kubik
>>
>>
> NACK
>
> [mbasti at dhcp129-96 freeipa-devel]$ git show -U0 | pep8 --diff
> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:528:80: E501 line 
> too long (95 > 79 characters)
> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: E101 
> indentation contains mixed spaces and tabs
> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: W191 
> indentation contains tabs
> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:1: E101 
> indentation contains mixed spaces and tabs
> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:80: E501 line 
> too long (95 > 79 characters)
> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: E101 
> indentation contains mixed spaces and tabs
> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: W191 
> indentation contains tabs
> ./ipatests/test_xmlrpc/test_permission_plugin.py:821:80: E501 line too 
> long (99 > 79 characters)
> ./ipatests/test_xmlrpc/test_permission_plugin.py:884:80: E501 line too 
> long (99 > 79 characters)
>
Sorry for that. Updated patch attached.

-- 
Milan Kubik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160225/9a3c9570/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0034-2-ipatests-extend-permission-plugin-test-with-new-expe.patch
Type: text/x-patch
Size: 3457 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160225/9a3c9570/attachment.bin>