[Freeipa-devel] [patch 0034] ipatests: extend permission plugin test with new expected output

[Martin Basti]

On 25.02.2016 09:52, Milan Kubík wrote:
> On 02/24/2016 07:05 PM, Martin Basti wrote:
>>
>>
>> On 24.02.2016 08:34, Milan Kubík wrote:
>>> On 02/18/2016 03:52 PM, Milan Kubík wrote:
>>>> On 02/15/2016 04:59 PM, Milan Kubík wrote:
>>>>> Patch attached. Applies on ipa-4-3 as well.
>>>>>
>>>>>
>>>>>
>>>> Updated version of patch fixes test_old_permission_plugin as well.
>>>>
>>>> -- 
>>>> Milan Kubik
>>>>
>>>>
>>> Review bump.
>>>
>>> -- 
>>> Milan Kubik
>>>
>>>
>> NACK
>>
>> [mbasti at dhcp129-96 freeipa-devel]$ git show -U0 | pep8 --diff
>> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:528:80: E501 
>> line too long (95 > 79 characters)
>> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: E101 
>> indentation contains mixed spaces and tabs
>> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:586:1: W191 
>> indentation contains tabs
>> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:1: E101 
>> indentation contains mixed spaces and tabs
>> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:587:80: E501 
>> line too long (95 > 79 characters)
>> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: E101 
>> indentation contains mixed spaces and tabs
>> ./ipatests/test_xmlrpc/test_old_permission_plugin.py:591:1: W191 
>> indentation contains tabs
>> ./ipatests/test_xmlrpc/test_permission_plugin.py:821:80: E501 line 
>> too long (99 > 79 characters)
>> ./ipatests/test_xmlrpc/test_permission_plugin.py:884:80: E501 line 
>> too long (99 > 79 characters)
>>
> Sorry for that. Updated patch attached.
>
> -- 
> Milan Kubik
ACK

Pushed to:
master: b32c9d639ef8e3fa852fb07f9385ae7e7b48e00e
ipa-4-3: 5ae12641426427552406af89feb15e9bcbad8db3

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160225/dfb83426/attachment.htm>