[Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

[Milan Kubík]

On 06/16/2016 03:23 PM, Lenka Doudova wrote:
> Hi,
>
> attached are tests for authentication indicators. Please note:
>
> 1. newly created service tracker is not exactly complete, list of 
> unimplemented methods is in doc. These methods can be filled in when 
> existing declarative tests are refactored.
>
> 2. patch 0015 depends on 0014, so it should not be pushed without it.
>
>
> Lenka
>
>
>

patch 0014:

In the update method, what happens when the updated attributes contain 
addattr? It is not clear to me. Is it necessary?

patch 0015:

host1 and service2 do not tell anything about the purpose of the 
fixture. Please assign more descriptive names to them.
Why do the fixtures have 'function' scope? Does the service entry exist 
during the second and third test case?

patch 0016:

Per offline discussion, admin user has no special privileges here, LGTM.

-- 
Milan Kubik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160701/e2820c01/attachment.htm>