[Freeipa-devel] [PATCH 0014-0016][Tests] Authentication indicators

[Lenka Doudova]

On 07/01/2016 02:42 PM, Milan Kubík wrote:
> On 06/16/2016 03:23 PM, Lenka Doudova wrote:
>> Hi,
>>
>> attached are tests for authentication indicators. Please note:
>>
>> 1. newly created service tracker is not exactly complete, list of 
>> unimplemented methods is in doc. These methods can be filled in when 
>> existing declarative tests are refactored.
>>
>> 2. patch 0015 depends on 0014, so it should not be pushed without it.
>>
>>
>> Lenka
>>
>>
>>
>
> patch 0014:
>
> In the update method, what happens when the updated attributes contain 
> addattr? It is not clear to me. Is it necessary?
>
Example:
     ipa service-mod SRV --addattr="authind=radius"

Result:
     The way the tracker works, this adds /u'addattr="authind=radius"'/ 
to the list of expected results (result of /self.attrs.update(updates)/. 
Of course nothing like that appears anywhere, so in case there's the 
/--addattr/ option, it's necessary to ensure it won't get to the 
/self.attrs/ atribute.

> patch 0015:
>
> host1 and service2 do not tell anything about the purpose of the 
> fixture. Please assign more descriptive names to them.
> Why do the fixtures have 'function' scope? Does the service entry 
> exist during the second and third test case?
>
Renamed.
>
> patch 0016:
>
> Per offline discussion, admin user has no special privileges here, LGTM.
>
> -- 
> Milan Kubik

Thanks for review, fixed patches (14.2 and 15.2) attached.
Lenka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160701/2a0ae755/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ldoudova-0014.2-Tests-Tracker-class-for-services.patch
Type: text/x-patch
Size: 7240 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160701/2a0ae755/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ldoudova-0015.2-Tests-Authentication-indicators-xmlrpc-tests.patch
Type: text/x-patch
Size: 2946 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160701/2a0ae755/attachment-0001.bin>