[Freeipa-devel] [PATCH] 0004 Report missing certificate in external trust chain

[Florence Blanc-Renaud]

Hi,

thanks to Jan and Fraser for the review and the suggested error message. 
Please find the updated patch attached.

Flo.


On 06/02/2016 08:55 AM, Fraser Tweedale wrote:
> On Thu, Jun 02, 2016 at 07:54:31AM +0200, Jan Cholasta wrote:
>> Hi,
>>
>> On 30.5.2016 19:58, Florence Blanc-Renaud wrote:
>>> Hi all,
>>>
>>> this patch adds in the error message the missing certificate that caused
>>> i/pa-server-install --external-cert-file=.../ to fail.
>>>
>>> https://fedorahosted.org/freeipa/ticket/5792
>> I think someone may confuse "issuer" with the "issuer name" field in the
>> certificate, also IMO we should use "certificate" rather than "cert" in
>> error messages, so I would rather use something like "missing certificate
>> with subject '%s'" or maybe just "missing certificate '%s'".
>>
> Let us be as specific as possible; Honza's suggestion "missing
> certificate with subject '%s'" is preferable.
>
> Cheers,
> Fraser

-- 
Florence Blanc-Renaud
Identity Management Team, Red Hat

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160602/340ef0d1/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-frenaud-0004-2-Report-missing-certificate-in-external-trust-chain.patch
Type: text/x-patch
Size: 1518 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160602/340ef0d1/attachment.bin>