[Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

[Pavel Vomacka]

On 06/09/2016 10:15 AM, Pavel Vomacka wrote:
>
>
> On 06/08/2016 04:40 PM, Petr Vobornik wrote:
>> On 06/07/2016 10:07 AM, Pavel Vomacka wrote:
>>>
>>> On 06/06/2016 07:51 PM, Martin Basti wrote:
>>>>
>>>>
>>>> On 05.06.2016 18:34, Pavel Vomacka wrote:
>>>>> Hello,
>>>>>
>>>>> please review attached patches which add WebUI part of DNS 
>>>>> Locations feature.
>>>>>
>>>>> -- 
>>>>> Pavel^3 Vomacka
>>>>>
>>>>>
>>>> NACK
>>>>
>>>> 1)
>>>> When I edit location description and click on revert button, then 
>>>> that nice
>>>> location table just disappear :)
>>> It's the same situation as with using 'Save' button - reported here:
>>> https://fedorahosted.org/freeipa/ticket/5776 . I'll write there a 
>>> comment that
>>> revert button hides values in association tables.
>>>> 2)
>>>> Can we put a placeholder "100" (gray font or something) to Location 
>>>> weight in
>>>> server detail view? Because when weight is not specified then 
>>>> default is 100
>>> Placeholder added.
>>>
>>
>> 1. please add "disable_facet_tabs: true," to location details page.
>> There is no point to display single facet tab.
> Fixed.
>> 2. can we extend location_association_table the same witth as rule
>> tables are extended in sudo and hbac rules? IIRC it needs to use
>> specific section type of 'servers' section.
> Fixed.
>>
>> 3. the placeholder 100 should be also added to adder dialog in
>> location_association_table_widget
> I think that it can be confusing when user tries to move a server from 
> one location to another, because server might have set a weight 
> already and it can differ from 100. In this case user would see 
> placeholder 100 but in reality the weight of server would be different 
> (value set in previous location).
>> 4. Description could be textarea - to be consistent with hbac, sudo 
>> rules.
> Fixed.
>>
>> 5. "Information" section is called "General" or "$Entity Settings" on
>> other parts of Web UI. It should be consistent.
> Fixed.
>
> Patches attached.
>
> -- 
> Pavel^3 Vomacka
>>
>>
>
>
>
Another revision of patch 40, removed useless comma from ipa_init.json. 
Both patches attached.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/a29e05f2/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0039-Add-adapter-attribute-for-choosing-record.patch
Type: text/x-patch
Size: 1664 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/a29e05f2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0040-4-DNS-Locations-WebUI-part.patch
Type: text/x-patch
Size: 11412 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/a29e05f2/attachment-0001.bin>