[Freeipa-devel] [PATCH] 0036-38 webui: Server roles

[Pavel Vomacka]

On 06/08/2016 04:09 PM, Petr Vobornik wrote:
> On 06/05/2016 07:22 PM, Pavel Vomacka wrote:
>>
>> On 06/03/2016 03:10 PM, Petr Vobornik wrote:
>>> On 06/02/2016 01:40 PM, Pavel Vomacka wrote:
>>>> Hello,
>>>>
>>>> please review my patches which add webui for server roles.
>>>>
>>> Did not test yet. I'm waiting for rebase of backend.
>>>
>>> Patch 36: ACK (assuming it works when ^^ is available)
>>>
>>> Patch 37:
>>>
>>> 1. typo: 'overriden' - twice
>> Fixed.
>>> 2. 'create_column_link' is a bad name for the method. The method doesn't
>>> create a column link. It is a link's click handler. So the name should
>>> be e.g. on_column_link_click
>> Yes, this is better. Fixed.
>>> Patch 38:
>>>
>>> 1. in serverroles_nested_search_facet wouldn't it be better to override
>>> only get_refresh_command_options and maybe get_refresh_command_args
>>> instead of full create_refresh_command?
>>>
>> Fixed.
>>
>> Attached the whole patchset with edited patches.
>>
>> -- 
>> Pavel^3 Vomacka
> 1. Following line breaks navigation:
>     that.on_column_link_click(value, entity);
> it should be:
>     return that.on_column_link_click(value, entity);
>
Attached patches are rebased and updated according to new Server Role 
patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0036-2-Association-table-can-be-read-only.patch
Type: text/x-patch
Size: 1413 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/f42e068a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0037-3-Extend-table-facet.patch
Type: text/x-patch
Size: 5367 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/f42e068a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0038-3-Add-server-roles-on-topology-page.patch
Type: text/x-patch
Size: 9492 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/f42e068a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvomacka-0044-Search-facet-can-be-without-search-field.patch
Type: text/x-patch
Size: 1826 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160609/f42e068a/attachment-0003.bin>