[Freeipa-devel] [PATCH] 0036-38 webui: Server roles

[Petr Vobornik]

On 06/09/2016 05:39 PM, Pavel Vomacka wrote:
> 
> 
> On 06/08/2016 04:09 PM, Petr Vobornik wrote:
>> On 06/05/2016 07:22 PM, Pavel Vomacka wrote:
>>>
>>> On 06/03/2016 03:10 PM, Petr Vobornik wrote:
>>>> On 06/02/2016 01:40 PM, Pavel Vomacka wrote:
>>>>> Hello,
>>>>>
>>>>> please review my patches which add webui for server roles.
>>>>>
>>>> Did not test yet. I'm waiting for rebase of backend.
>>>>
>>>> Patch 36: ACK (assuming it works when ^^ is available)
>>>>
>>>> Patch 37:
>>>>
>>>> 1. typo: 'overriden' - twice
>>> Fixed.
>>>> 2. 'create_column_link' is a bad name for the method. The method
>>>> doesn't
>>>> create a column link. It is a link's click handler. So the name should
>>>> be e.g. on_column_link_click
>>> Yes, this is better. Fixed.
>>>> Patch 38:
>>>>
>>>> 1. in serverroles_nested_search_facet wouldn't it be better to override
>>>> only get_refresh_command_options and maybe get_refresh_command_args
>>>> instead of full create_refresh_command?
>>>>
>>> Fixed.
>>>
>>> Attached the whole patchset with edited patches.
>>>
>>> -- 
>>> Pavel^3 Vomacka
>> 1. Following line breaks navigation:
>>     that.on_column_link_click(value, entity);
>> it should be:
>>     return that.on_column_link_click(value, entity);
>>
> Attached patches are rebased and updated according to new Server Role
> patches.

ACK for all 4 patches.

pushed to master:
* 95c61c6a0b7d97a9f78fc5b83f38ce2b43cbebc4 Association table can be read
only
* 72fe7e3294fd2f0acdab161180609e9868c4a943 Extend table facet
* 1eb57600185f96e61d0894148a5f50870173c7cd Add server roles on topology page
* 31faf1c21d5635edfa9da23005a1942452a0248c Search facet can be without
search field

-- 
Petr Vobornik