[Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

Martin Basti mbasti at redhat.com
Thu Mar 31 11:10:59 UTC 2016



On 31.03.2016 12:07, Oleg Fayans wrote:
> Please, disregard it for a while, it does not pass lint.
>
> On 03/31/2016 12:05 PM, Oleg Fayans wrote:
>>
>>
NACK

Please send unrelated changes in separate patches. I do not see relation 
between changing variable names, adding assertion messages and setting 
replication sleep-a-bit wait.

IMO to the ticket in the patch only assertion changes are related.

For the pylint related errors:
assert ('any value', 'in tuple')
is always true.
right syntax is
assert (any test), ('error msg')

Martin^2




More information about the Freeipa-devel mailing list