[Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

[Oleg Fayans]

Hi Martin,

Thanks for the review. The updated patch(es) are included

Testrun output can be found here:

http://fpaste.org/347800/59421745/

On 03/31/2016 01:10 PM, Martin Basti wrote:
> 
> 
> On 31.03.2016 12:07, Oleg Fayans wrote:
>> Please, disregard it for a while, it does not pass lint.
>>
>> On 03/31/2016 12:05 PM, Oleg Fayans wrote:
>>>
>>>
> NACK
> 
> Please send unrelated changes in separate patches. I do not see relation
> between changing variable names, adding assertion messages and setting
> replication sleep-a-bit wait.

Agreed. There are two necessary bugfixes for the testsuite to run. They
were put into a separate patch

> 
> IMO to the ticket in the patch only assertion changes are related.
> 
> For the pylint related errors:
> assert ('any value', 'in tuple')
> is always true.
> right syntax is
> assert (any test), ('error msg')

thank you!

> 
> Martin^2

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0033.1-Added-assertion-error-messages-in-topology-tests.patch
Type: text/x-patch
Size: 7886 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160331/bccfdd47/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0034-Bugfixes-in-replication_topology-tests.patch
Type: text/x-patch
Size: 3950 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160331/bccfdd47/attachment-0001.bin>