[Freeipa-devel] [PATCH 0088-0095] Add --forward-policy option into installers

[Martin Basti]

On 21.03.2016 16:51, Petr Spacek wrote:
> On 10.3.2016 22:17, Lukas Slebodnik wrote:
>> On (10/03/16 22:14), Petr Spacek wrote:
>>> Hello,
>>>
>>> I forgot to send a patches before I leave, so here it is:
>>>
>>> Auto-detect default value for --forward-policy option in installers
>>>
>>> See
>>> https://fedorahosted.org/freeipa/ticket/5710
>>> commit messages, and design page
>>> https://fedorahosted.org/bind-dyndb-ldap/wiki/BIND9/Design/AutomaticEmptyZones
>>>
>>>
>>> I did not have time to test it thoroughly but it LGTM :-D
>>>
>>> Please note that this is first part, it does not solve upgrade (yet) and
>>> warnings in forwardzone-* interface.
>>>
>>> This can be solved in another patch set, this can be pushed if it passes review.
>>>
>> ENOPATH
> LOL, here it is.
>
>
>
  * Remove function ipapython.ipautil.host_exists() *
ACK


* Extend installers with --forward-policy option *
1)
There is no --forward-policy option in ipa-dns-install


* Move automatic empty zone list into ipapython.dnsutil and make it 
reusable *
ACK


* Add assert_absolute_dnsname() helper to ipapython.dnsutil *
ACK


* Move function is_auto_empty_zone() into ipapython.dnsutil *
ACK


* Use shared sanity check and tests ipapython.dnsutil.is_auto_empty_zone() *
ACK

* Add function ipapython.dnsutil.inside_auto_empty_zone() *
ACK

* Auto-detect default value for --forward-policy option in installers *
LGTM, but ipa-dns-install is missing option --forward-policy

# ipa-dns-install
...
Unexpected error - see /var/log/ipaserver-install.log for details:
AttributeError: Values instance has no attribute 'forward_policy'


Summary: 6 ACKs, 1 LGTM, 1 NACK => NACK

Martin^2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160331/36b890b0/attachment.htm>