[Freeipa-devel] [TESTS][PATCH 0012] Provide cleanup for host certificate

Martin Basti mbasti at redhat.com
Tue May 3 10:15:34 UTC 2016



On 03.05.2016 11:18, Lenka Doudova wrote:
>
>
> On 05/03/2016 10:33 AM, Martin Basti wrote:
>> Hello I'm quite confused what is happening in that code, can you 
>> explain it more to me? I see duplicated code there.
> Sorry, that was just an unnecessary leftover. Fixed patch attached.
> The code is expected to remove any certificates that were added to the 
> local host but not to try to remove the host itself.
>
> Lenka
>>
>>
>> Martin^2
>
Looks better, please follow proper naming of patches according how to 
format patch guide.
I propose following (Patch attached) changes. It looks weird to me to 
return self object

Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-9999-proposed-changes.patch
Type: text/x-patch
Size: 1833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160503/ec37015d/attachment.bin>


More information about the Freeipa-devel mailing list