[Freeipa-devel] [TESTS][PATCH 0012] Provide cleanup for host certificate

[Lenka Doudova]

On 05/03/2016 12:15 PM, Martin Basti wrote:
>
>
> On 03.05.2016 11:18, Lenka Doudova wrote:
>>
>>
>> On 05/03/2016 10:33 AM, Martin Basti wrote:
>>> Hello I'm quite confused what is happening in that code, can you 
>>> explain it more to me? I see duplicated code there.
>> Sorry, that was just an unnecessary leftover. Fixed patch attached.
>> The code is expected to remove any certificates that were added to 
>> the local host but not to try to remove the host itself.
>>
>> Lenka
>>>
>>>
>>> Martin^2
>>
> Looks better, please follow proper naming of patches according how to 
> format patch guide.
> I propose following (Patch attached) changes. It looks weird to me to 
> return self object
>
> Martin
>
Ok, fixed patch attached.

Thanks,
Lenka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012.2-Test-fix-Cleanup-for-host-certificate.patch
Type: text/x-patch
Size: 2455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160503/51d62fa6/attachment.bin>