[Freeipa-devel] [PATCH 0477] upgrade: always start CA

[Stanislav Laznicka]

NACK, see my comments below

+    # following upgrade steps require running CA

This is a nitpicky nitpick but could you please change this comment for 
# the following ...
Took me a while to understand what you were trying to say here.

+    if ca_running and not ca.is_running():
+        ca.stop('pki-tomcat')
+    elif not ca_running and ca.is_running():
+        ca.start('pki-tomcat')
+

You should swap ca.stop and ca.start here, you're stopping the service 
when it's stopped and starting it when it's already running.

On 05/12/2016 04:34 PM, Martin Basti wrote:
> Patch attached.
>
> https://fedorahosted.org/freeipa/ticket/5868
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160519/c459c2e8/attachment.htm>