[Freeipa-devel] [freeipa PR#140][comment] Tests: Remove invalid certplugin tests

pvomacka freeipa-github-notification at redhat.com
Thu Oct 6 07:21:35 UTC 2016


  URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests

pvomacka commented:
"""
I think that it is not good idea to remove tests, because we are lowering coverage. Therefore NACK. 

Could we rather rewrite these tests? For example issue certain certificates, revoke them and then test whether there are revoked certs with correct revocation reason. I think that our Tracker could help with it. 
"""

See the full comment at https://github.com/freeipa/freeipa/pull/140#issuecomment-251886076


More information about the Freeipa-devel mailing list