[Freeipa-devel] [freeipa PR#140][comment] Tests: Remove invalid certplugin tests

mirielka freeipa-github-notification at redhat.com
Thu Oct 6 07:32:12 UTC 2016


  URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests

mirielka commented:
"""
Hi, I discussed this with Rob who authored the tests and he said that these tests were there just as a kind of checking that no extra revoked certificates get in. Tests are cca 4 years old, revoked certificates do get in e.g. due to changes in Dogtag (they can be created by other tests and can't be deleted) and cert tests fail. Creating new tests as you described (create cert, revoke it and check it's in the database with correct info) could be separate task, since these tests didn't do such think, they just checked what's already in regardless of how it got there.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/140#issuecomment-251887928


More information about the Freeipa-devel mailing list