[Freeipa-devel] [freeipa PR#337][comment] Client-side CSR autogeneration (take 2)
HonzaCholasta
freeipa-github-notification at redhat.com
Mon Jan 30 13:01:33 UTC 2017
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
HonzaCholasta commented:
"""
Before I push this, could you please:
* squash "Fix broken tests in CSR autogeneration" into "Add tests for CSR autogeneration",
* add module prefix to commit subjects ("csrgen:", "tests:", etc.),
* make the terminology used in commit messages consistent ("CSR generation" vs. "CSR autogeneration", "certificate mapping" vs. "cert profile" vs. "CSR generation profile" vs. "CSR template" vs. ... - FTR my favorites are "CSR generation" and "CSR template")
?
"""
See the full comment at https://github.com/freeipa/freeipa/pull/337#issuecomment-276056949
More information about the Freeipa-devel
mailing list