[almighty] Code review integration

[Pranav Gore]

Hi,

How can I remove "reviewable" checks from PR ?



On Mon, Jan 2, 2017 at 7:55 PM, Konrad Kleine <kkleine at redhat.com> wrote:

> Aslak,
>
> good point! I've disabled the repos on reviewable and also hard-deleted
> the webhook from github. Previously I only deactivated it.
>
> On Mon, Jan 2, 2017 at 1:02 PM, Aslak Knutsen <aslak at redhat.com> wrote:
>
>> Hmm.. interesting...
>>
>> They seem to be using one of the 'repo admins' tokens to re-enable the
>> hook/config.
>>
>> I've deleted the access to my account now. Konrad?
>>
>> -aslak-
>>
>> On Mon, Jan 2, 2017 at 9:36 AM, Shoubhik Bose <shbose at redhat.com> wrote:
>>
>>> "Reviewable" webhook seems to be active yet again in
>>> almighty/almighty-core , any clue why it was done? :)
>>>
>>> On Mon, Sep 19, 2016 at 8:12 PM, Todd Mancini <tmancini at redhat.com>
>>> wrote:
>>>
>>>> Lack of sleep and context did not help here. Ignore me.
>>>>
>>>> On Sun, Sep 18, 2016 at 8:11 PM, Aslak Knutsen <aslak at redhat.com>
>>>> wrote:
>>>>
>>>>> Don't listen to Todd, his answering in his sleep... :)
>>>>>
>>>>> The main reason we moved to Reviewable was to keep track of
>>>>> 'unanswered' comments during large reviews. I'm not seeing 100% how the new
>>>>> GitHub review fixes this, but, the new GitHub Review definitely has nicer
>>>>> reviews than before and with generally smaller pull requests I think we
>>>>> should be able to use it with no problem.
>>>>>
>>>>> My take would be; Let's try GitHub Review for a while and see if it
>>>>> works for what we need. If not, we can move back to Reviewable later.
>>>>>
>>>>> -aslak-
>>>>>
>>>>> On Sun, Sep 18, 2016 at 9:06 PM, Todd Mancini <tmancini at redhat.com>
>>>>> wrote:
>>>>>
>>>>>> Yes, we should continue with our implementation. There are many
>>>>>> reasons, but the main reason is that, although we are using GitHub today,
>>>>>> the future plans do not require GitHub.
>>>>>>
>>>>>> Sent from my phone, so anticipate hilarious autocorrects
>>>>>> ------------------------------
>>>>>> From: Shoubhik Bose <shbose at redhat.com>
>>>>>> Sent: ‎9/‎16/‎2016 2:57 AM
>>>>>> To: ALMighty-public <almighty-public at redhat.com>
>>>>>> Subject: [almighty] Code review integration
>>>>>>
>>>>>> Github has added new features for tracking code review , should we be
>>>>>> continuing with reviewable ?
>>>>>>
>>>>>> _______________________________________________
>>>>>> almighty-public mailing list
>>>>>> almighty-public at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/almighty-public
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>> _______________________________________________
>>> almighty-public mailing list
>>> almighty-public at redhat.com
>>> https://www.redhat.com/mailman/listinfo/almighty-public
>>>
>>>
>>
>> _______________________________________________
>> almighty-public mailing list
>> almighty-public at redhat.com
>> https://www.redhat.com/mailman/listinfo/almighty-public
>>
>>
>
> _______________________________________________
> almighty-public mailing list
> almighty-public at redhat.com
> https://www.redhat.com/mailman/listinfo/almighty-public
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/almighty-public/attachments/20170103/16bd6755/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: reviewable_disconnected.png
Type: image/png
Size: 74666 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/almighty-public/attachments/20170103/16bd6755/attachment.png>