[augeas-devel] Re: [Interfaces] Draft lense

[Raphaël Pinson]

On Fri, Aug 22, 2008 at 2:30 PM, Free Ekanayaka <free at 64studio.com> wrote:

> I works, you're a wizard! The lense is now acceptable, I'm sure there
> are some corner cases which are not yet covered, but it should be fine
> for most real-life cases.



Great, this lens is a very useful one for sure (at least for Debian/Ubuntu
users ;)). Nicolas will be happy of it!



> RP> This is getting ugly... and will probably require quite a few comments
> in
>  RP> the lens for further readers ;)
>
> Definitely. I was thinking to the possibility of nesting nodes of
> trailing comments inside a values/options nodes, so that:
>
> auto eth0 # Whatever
>
> would generate:
>
> { "auto"
>   { "1" = "eth0
>       { "#comment" = "Whatever } } }
>
> while:
>
> auto eth0
> # Whatever
>
> would lead to:
>
> { "auto"
>   { "1" = "eth0 } }
> { "#comment" = "Whatever }
>
> I have the feeling that it would simplifiy things, but I'm not
> sure.



I don't think it's a good idea, because you can have several iface arguments
after auto. How will you map

auto lo eth0 # loopback & eth card

Imo, this comment is about both "lo" and "eth0" so it would be

{ "auto"
   { "1" = "lo" }
   { "2" = "eth0" }
   { "#comment" = "loopback & eth card" } }

and it wouldn't really make sense to have

{ "auto"
   { "1" = "lo" }
   { "2" = "eth0"
      { "#comment" = "loopback & eth card" } } }


Could you send a patch (using hg email) to the list with interfaces.aug and
test_interfaces.aug ? I'm sure David will be happy to apply it to the repo
once he gets back :)

If you're not familiar with hg (I was not at all):

cat << EOF > ~/.hgrc
[email]
from = Name <email>
method = smtp

[smtp]
host = your smtp gateway

[ui]
username = Name <email>
EOF
hg ci interfaces.aug tests/test_interfaces.aug
hg log interfaces.aug # find the hash for the commit
hg email -t "Augeas config <augeas-devel at redhat.com>" $hash



Ciao


Raphaël
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20080822/d276b693/attachment.htm>