[Avocado-devel] Broken cartesian_config by commit 81c6ce860b2f625e

[Andrei Stepanov]

https://github.com/avocado-framework/avocado-vt/pull/668

On Thu, Aug 18, 2016 at 2:39 PM, Cleber Rosa <crosa at redhat.com> wrote:

> On 08/18/2016 06:50 AM, Andrei Stepanov wrote:
> > Hello.
> >
>
> Hi Andrei,
>
> > We have now broken cartesian_config.py.
> >
> > It was broken by:
> >
> > commit 81c6ce860b2f625ec31533779c479cf9bf14af38
> > Author: Xu Tian <xutian at redhat.com>
> > Date:   Mon May 23 15:10:48 2016 +0800
> >
> >     virttest.cartesian_config: enable postfix_parse
> >
> >     postfix string '_fixed', '_max' and '_min' doesn't work, because
> >     'postfix_parse' not call in get_dict function. this commit enable
> >     it, because tp-qemu tests need these params.
> >
> >     Signed-off-by: Xu Tian <xutian at redhat.com>
> >
> >
> >
> > The error is:
> >
> > [root at localhost cfg]# cartesian_config.py tests.cfg
> > Traceback (most recent call last):
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 2301, in <module>
> >     print_dicts(options, dicts)
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 2187, in print_dicts
> >     print_dicts_default(options, dicts)
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 2160, in print_dicts_def
> > ault
> >     for count, dic in enumerate(dicts):
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 1939, in get_dicts
> >     for d in self.get_dicts_plain(node, ctx, content, shortname, dep):
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 2145, in get_dicts_plain
> >     for d in self.get_dicts(n, ctx, new_content, shortname, dep):
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 1939, in get_dicts
> >     for d in self.get_dicts_plain(node, ctx, content, shortname, dep):
> >
> > .....
> >
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 2145, in get_dicts_plain
> >     for d in self.get_dicts(n, ctx, new_content, shortname, dep):
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 1942, in get_dicts
> >     postfix_parse(d)
> >   File "/mnt/tests/spice/qe-tests/avocado-vt/virttest/cartesian_
> config.py",
> > line 2244, in postfix_parse
> >     if key.endswith("_max"):
> > AttributeError: 'tuple' object has no attribute 'endswith'
> >
> >
> > If I do:
> >
> > git revert 81c6ce860b2f625ec31533779c479cf9bf14af38
> >
> > than I do not have such error. Please fix.
> >
>
> Please propose the revert as a PR.  Xu and the others Avocado-VT
> maintainers can review, comment and (optionally) apply your proposal.
>
> Thanks!
>
>
> --
> Cleber Rosa
> [ Sr Software Engineer - Virtualization Team - Red Hat ]
> [ Avocado Test Framework - avocado-framework.github.io ]
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/avocado-devel/attachments/20160818/41ca6763/attachment.htm>