[Avocado-devel] Collaboration Workflow

Wei, Jiangang weijg.fnst at cn.fujitsu.com
Fri Jun 3 07:06:00 UTC 2016


On Fri, 2016-06-03 at 08:48 +0200, Amador Pahim wrote:
> On 05/31/2016 11:09 AM, Amador Pahim wrote:
> > Hello,
> >
> > We are receiving a good number of Pull Requests from new contributors
> > and this is great.
> >
> > In order to optimize the time spent on code reviews and also the time
> > the code writers are investing in adjust the code according to the
> > reviews, I'd like to expose my own workflow that I believe is close to
> > the workflow used by the others full-time avocado developers.
> >
> > The hope is that the new comers get inspired by this and probably take
> > advantage of it.
> >
> 
> Thank you for the feedback. We got 2 more workflow tips ('set spell' on 
> vim and branch cleanup on your github fork).
Thanks for your reminds.
I received  message "<apahim at redhat.com> was undeliverable.",
so I resend it again....
sorry for the inconvenience. 

There're some typos in PR, especially in origin repo,
Usually We pay more attention to review the functionality of PR and
neglect typo.
And The CI can check the indent and style problems, but not spelling
mistake.

That‘s why I want to add  the 'spelling check' hint for contributor.

wei

> 
> Also, I'd recommend to try to avoid the travis check failure by running 
> locally the checks that travis is going to run when you create the pull 
> request. You can look the .travis.yml file in each repository to have 
> the list of commands. For avocado-misc-tests, they're only syntax check:
> 
>   $ inspekt lint
>   $ inspekt indent
>   $ inspekt style
> 
> 
> The full work here will be part of our docs soon, as Cleber pointed out.
> 
> Best,
> apahim
> 
> _______________________________________________
> Avocado-devel mailing list
> Avocado-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/avocado-devel
> 
> 







More information about the Avocado-devel mailing list