[Avocado-devel] avocado-vt "make check" output

[Cleber Rosa]

On 9/13/18 10:04 PM, Xiong, Huan wrote:
> Hi,
> 
> I have a few simple fixes for avocado-vt to get virito console tests running on aarch64 (e.g., passing -machine option to "qemu -device ?" command because qemu doesn't define a default machine type for aarch64 guests). I'm following the instructions on https://avocado-framework.readthedocs.io/en/latest/ContributionGuide.html to prepare a PR. But I'm getting stuck at this step:
> 
> "Make sure your code is working (install your version of avocado, test your change, run make check to make sure you didn't introduce any regressions).
> 
> Paste the job.log file content from the previous step in a pastebin service, like fpaste.org."
> 
> I manage to get inspector working on my machine, but the "make check" output doesn't look good:
> 
> https://paste.fedoraproject.org/paste/0dPwYymATvsHpiZpOQcr8Q
> 
> (FWIW, I ran into an odd Python3 setuptools internal error while installing inspector on my system, and worked around it by using python 2 and older versions of pylint and asteroid. I suppose that's irrelevant to the coding style issues above.)
> 
> My code change is simple and unlikely to introduce these issue. Can I ignore them? Thanks for any suggestion.
> 
> Ray
> 

Hi Ray,

Sorry for taking so long to reply.  Now, the paste has expired, and I
can't comment properly.

But, in general lines, if your code is not introducing a breakage,
reviewers will probably take that into consideration.

Have you managed to send PRs? If so, please request my review via GH and
I'll take a look at them.

Thanks,

-- 
Cleber Rosa
[ Sr Software Engineer - Virtualization Team - Red Hat ]
[ Avocado Test Framework - avocado-framework.github.io ]
[  7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3  ]