[Cluster-devel] Re: clulog

[Fabio M. Di Nitto]

Lon Hohberger wrote:

> 
> Really - what we need is a better logging system.  clulog is just a
> wrapper around syslog.

Yes exactly as some other log.c/.h that are around the tree.

>  Some of the features we really need are:
> 
>  * ring-buffer style (w/ a fixed max size)
>    * Remove oldest / lowest-prio log messages if we run out of
>      room
>  * option of guaranteed non-blocking logging
> 
> clulog could be expanded and library-ified - esp. now that we have a
> better / single build system.
> 
> What I'd do is:
> 
>   * clulog_init(const char *facility, int mode, int severity)
> 	  MODE_SIMPLE   - what we have now.
>       MODE_NONBLOCK - simple nonblocking syslog() calls.  e.g. do what
> 		syslog() does, but open the log device O_NONBLOCK; lossy.
>       MODE_RINGBUF  - Non-blocking; fixed maximum memory footprint.
>         Clears lowest-prio / oldest log messages first if we fill up.
> 
> etc... etc...  I'll do more on this later. 

How would you feel if we first extract the code in its own library,
switch all the subproject to it and then implement features?

I think that in this way we will have to look at much less code than we
have now.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.