[Crash-utility] Two small issues in is_compressed_kernel()
HATAYAMA Daisuke
d.hatayama at jp.fujitsu.com
Mon Apr 4 04:15:35 UTC 2011
When I was using crash 5.1.4, I found two small issues in
is_compressed_kernel().
1) For vmlinux compressed with bzip2, is_compressed_kernel() is
forgetting to use basename() to a given file name before comparing it
with "vmlinux", due to which specifying vmlinux by relative or
absolute path lets a given vmlinux unintensionally interpreted as an
unsuported format. See an attached patch, though it's very obvious.
2) is_compressed_kernel() is assuming gunzip and bunzip2 are located
in /usr/bin/, but on Ubuntu they are located in /bin/, so
uncompression fails on Ubuntu due to No such file error. Could you add
a static or dynamic processing of detecting where binaries are
located?
Thanks.
HATAYAMA, Daisuke
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-basename-to-compare-a-given-vmlinux-name-with-vm.patch
Type: text/x-patch
Size: 787 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20110404/a601f216/attachment.bin>
More information about the Crash-utility
mailing list