[Crash-utility] Two small issues in is_compressed_kernel()

[Dave Anderson]

----- Original Message -----
> When I was using crash 5.1.4, I found two small issues in
> is_compressed_kernel().
> 
> 1) For vmlinux compressed with bzip2, is_compressed_kernel() is
> forgetting to use basename() to a given file name before comparing it
> with "vmlinux", due to which specifying vmlinux by relative or
> absolute path lets a given vmlinux unintensionally interpreted as an
> unsuported format. See an attached patch, though it's very obvious.

Yes it sure is -- queued for the next release.  Thanks!

> 2) is_compressed_kernel() is assuming gunzip and bunzip2 are located
> in /usr/bin/, but on Ubuntu they are located in /bin/, so
> uncompression fails on Ubuntu due to No such file error. Could you add
> a static or dynamic processing of detecting where binaries are located?

Sure -- I'll fix that in the next release.

Thanks,
  Dave
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 787 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20110404/c104636b/attachment.bin>