[Crash-utility] [PATCH v1 0/2] Compressed KDUMP core analysis support for PPC32

Dave Anderson anderson at redhat.com
Wed Jan 18 22:06:33 UTC 2012



----- Original Message -----
> 
> I don't feel comfortable accepting this piece as is -- can you
> restrict it to just PPC?:
> 
> --- a/netdump.c
> +++ b/netdump.c
> @@ -1696,6 +1696,8 @@ dump_Elf32_Nhdr(Elf32_Off offset, int store)
>                                 }
>                         }
>                 }
> +               if (nd->num_prstatus_notes > 0)
> +                       pc->flags2 |= ELF_NOTES;
>                 break;
>         case NT_PRPSINFO:
>                 netdump_print("(NT_PRPSINFO)\n");
> 

Actually, for that matter, why is it even there?  You're already 
setting ELF_NOTES in ppc_process_elf_notes() the same way
that the X86 does it in x86_process_elf_notes(). 

Dave




More information about the Crash-utility mailing list