[Crash-utility] [PATCH v1 0/2] Compressed KDUMP core analysis support for PPC32

[Suzuki K. Poulose]

  Dave Anderson wrote:
>
>
> ----- Original Message -----
>>
>> I don't feel comfortable accepting this piece as is -- can you
>> restrict it to just PPC?:
>>
>> --- a/netdump.c
>> +++ b/netdump.c
>> @@ -1696,6 +1696,8 @@ dump_Elf32_Nhdr(Elf32_Off offset, int store)
>>                                  }
>>                          }
>>                  }
>> +               if (nd->num_prstatus_notes>  0)
>> +                       pc->flags2 |= ELF_NOTES;
>>                  break;
>>          case NT_PRPSINFO:
>>                  netdump_print("(NT_PRPSINFO)\n");
>>
>
> Actually, for that matter, why is it even there?  You're already
> setting ELF_NOTES in ppc_process_elf_notes() the same way
> that the X86 does it in x86_process_elf_notes().

ppc_process_elf_notes is called only for diskdump, not for netdump.
And all the process_elf_notes(), update the diskdump_data->nt_prstatus_percpu[],
which(dd) is not available in the arch specific files.


Thanks
Suzuki


>
> Dave
>