[Crash-utility] 'crash' compilation on Arch fails with -D_FORTIFY_SOURCE=2

[Dave Anderson]

----- Original Message -----
> Hi,
> 
> Starting from recently Arch uses -D_FORTIFY_SOURCE=2 flag for
> compilation that seems affects latest glibc. This flag causes 'crash
> tool' compilation error on Arch:

I'm not familiar with "Arch", aside from what I can see in the 
https://www.archlinux.org web site.  Anyway, I'm guessing that
this may be only the first of a cascading set of these kinds
of warnings when the embedded gdb-7.3.1 is built, since it apparently
stops the build on the first file that generates a warning.  If you're
lucky, maybe it's only a handful?  

Anyway, if you cannot turn off the -D_FORTIFY_SOURCE=2 flag, or
set it to 1, for the crash utility build, then it obviously would
require patches for dealing with each complaint.   

What version of gdb comes with "Arch"?  Presuming that its version of gdb
also gets built with -D_FORTIFY_SOURCE=2, then perhaps they (GNU) have
dealt with these warnings in a later version of gdb?  Or perhaps the
"Arch" maintainers have patched their version of gdb?  In either case,
you could look at what GNU (or Arch) did with their version of of gdb to 
address the warnings in order to come up with a set of patches for the 
gdb-7.3.1 used by the crash utility.

If they're not overwhelming, I'll certainly consider taking them in.

Dave


> /fibheap.c:265:7: warning: implicit declaration of function ‘abort’
> [-Wimplicit-function-declaration]
> abort ();
> ^
> ./fibheap.c:265:7: warning: incompatible implicit declaration of
> built-in function ‘abort’ [enabled by default]
> ./fibheap.c: In function ‘fibheap_delete’:
> ./fibheap.c:277:5: warning: incompatible implicit declaration of
> built-in function ‘free’ [enabled by default]
> free (fibheap_extr_min_node (heap));
> ^
> ./fibheap.c: In function ‘fibheap_consolidate’:
> ./fibheap.c:368:3: warning: implicit declaration of function ‘memset’
> [-Wimplicit-function-declaration]
> memset (a, 0, sizeof (fibnode_t) * D);
> ^
> ./fibheap.c:368:3: warning: incompatible implicit declaration of
> built-in function ‘memset’ [enabled by default]
> make[4]: *** [fibheap.o] Error 1
> make[3]: *** [all-libiberty] Error 2
> make[2]: *** [all] Error 2
> 
> gdb build failed: gdb-7.3.1/gdb/libgdb.a does not exist
> 
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://www.redhat.com/mailman/listinfo/crash-utility