[Crash-utility] patch for slight modification to runq -g command

Dave Anderson anderson at redhat.com
Thu Nov 14 18:22:06 UTC 2013



----- Original Message -----
> Hi Dave,
> 
> The rb_root pointer is pretty useless in our debugging. I thought about
> removing it but decided not to do it thinking other people may need it.
> I can get you another patch that removes the rb_root display from the
> "group" line. Please let me know what you think.

OK good, that's what I figured.  And since the cfs_rq address is being
displayed now, if it's really necessary to see the the rb_root, it can 
easily be accessed from there.

No need for another patch -- I've been tinkering with the results of
your changes.

Thanks again,
  Dave

> 
> Thanks,
> Anthony
> 
>     > -----Original Message-----
>     > From: crash-utility-bounces at redhat.com [mailto:crash-utility-
>     > bounces at redhat.com] On Behalf Of Dave Anderson
>     > Sent: Wednesday, November 13, 2013 1:51 PM
>     > To: Discussion list for crash utility usage, maintenance and
>     > development
>     > Subject: Re: [Crash-utility] patch for slight modification to runq -g
>     > command
>     > 
>     > 
>     > 
>     > ----- Original Message -----
>     > >
>     > >
>     > > ----- Original Message -----
>     > > > My mistake, I didn't read your email carefully enough. Here's the
>     > > > new
>     > > > patch.
>     > > >
>     > > > Thanks,
>     > > > Anthony
>     > >
>     > > Thanks Anthony -- your changes are queued for crash-7.0.4.
>     > >
>     > > Dave
>     > 
>     > Anthony,
>     > 
>     > Given your interest in this command, I have a question re: the display.
>     > 
>     > Do you ever have any interest in the rb_root addresses in each group?
>     > I'm thinking that with your patch adding the task_group and cfs_rq
>     > addresses, that the rb_root address is fairly useless.  It was
>     > pretty much carried forward from the base "runq" command display,
>     > where it makes some sense.
>     > 
>     > Dave
>     > 
>     > 
>     > --
>     > Crash-utility mailing list
>     > Crash-utility at redhat.com
>     > https://www.redhat.com/mailman/listinfo/crash-utility
> 




More information about the Crash-utility mailing list