[Crash-utility] Value of

[Karlsson, Jan]

Hi Dave

I was looking in the file arm64.c at function arm64_translate_pte and saw the line:

  if (!page_present && (pte & PTE_FILE)) {

I also saw that there are two versions of the value PTE_FILE (see also defs.h) and the following code is included in arm64.c in arm64_init:

    if (THIS_KERNEL_VERSION >= LINUX(3,10,0)) {
      machdep->machspec->pte_protnone = PTE_PROT_NONE_3_10;
      machdep->machspec->pte_file = PTE_FILE_3_10;
    } else {
      machdep->machspec->pte_protnone = PTE_PROT_NONE;
      machdep->machspec->pte_file = PTE_FILE;
    }

So should not the first mentioned line be changed to:

  if (!page_present && (pte & machdep->machspec->pte_file)) {

Jan

Jan Karlsson
Senior Software Engineer
System Assurance

Sony Mobile Communications
Tel: +46 703 062 174
jan.karlsson at sonymobile.com<mailto:Firstname.Lastname at sonymobile.com>

sonymobile.com<http://sonymobile.com/>

[cid:image001.gif at 01D08325.5A5F0670]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20150430/aeace64d/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1749 bytes
Desc: image001.gif
URL: <http://listman.redhat.com/archives/crash-utility/attachments/20150430/aeace64d/attachment.gif>