[Crash-utility] Value of

[Dave Anderson]

----- Original Message -----
> 
> 
> Hi Dave
> 
> I was looking in the file arm64.c at function arm64_translate_pte and saw the
> line:
> 
> if (!page_present && (pte & PTE_FILE)) {
> 
> I also saw that there are two versions of the value PTE_FILE (see also
> defs.h) and the following code is included in arm64.c in arm64_init :
> 
> if (THIS_KERNEL_VERSION >= LINUX(3,10,0)) {
> 
> machdep->machspec->pte_protnone = PTE_PROT_NONE_3_10;
> 
> machdep->machspec->pte_file = PTE_FILE_3_10;
> 
> } else {
> 
> machdep->machspec->pte_protnone = PTE_PROT_NONE;
> 
> machdep->machspec->pte_file = PTE_FILE;
> 
> }
> 
> So should not the first mentioned line be changed to:
> 
> if (!page_present && (pte & machdep->machspec->pte_file)) {
> 
> Jan

It was in a state of flux when that code was originally put in place, 
and I see now that it's changed yet again, where PTE_FILE and PTE_PROT_NONE
don't even exist anymore upstream.

So it certainly needs revisiting...

Dave