[Crash-utility] [PATCH] extensions/eppic.mk: Remove ping check to github.com

HAGIO KAZUHITO(萩尾 一仁) k-hagio-ab at nec.com
Mon Dec 21 06:18:43 UTC 2020


Without this patch, in an environment where ping to github.com does
not work, building eppic.so fails with the message "eppic.so: failed
to pull eppic code from git repo" and "make clean" at the top-level
crash directory unnecessarily takes about 10 seconds every time.

  $ time make clean
  ...
  real    0m10.398s

Signed-off-by: Kazuhito Hagio <k-hagio-ab at nec.com>
---
 extensions/eppic.mk | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/extensions/eppic.mk b/extensions/eppic.mk
index c79170a596b7..7486ce46a6b8 100644
--- a/extensions/eppic.mk
+++ b/extensions/eppic.mk
@@ -24,7 +24,6 @@ ifeq ($(TARGET), X86)
 endif
 
 APPFILE=eppic/applications/crash/eppic.c
-GITHUB := $(shell ping -c 1 github.com | grep "1 received")
 GIT := $(shell which git 2> /dev/null)
 
 all:
@@ -38,9 +37,7 @@ all:
              if [ -n "$(EPPIC_GIT_URL)" ]; then \
                git clone "$(EPPIC_GIT_URL)" eppic; \
              else \
-	          if [ -n "$(GITHUB)" ] ; then \
-		    git clone https://github.com/lucchouina/eppic.git eppic; \
-	          fi; \
+               git clone https://github.com/lucchouina/eppic.git eppic; \
              fi; \
           else \
 	     if [ ! -f "$(GIT)" ]; then \
-- 
2.18.4





More information about the Crash-utility mailing list