[Crash-utility] [PATCH] fix minor spelling typos in symbols.c
HAGIO KAZUHITO(萩尾 一仁)
k-hagio-ab at nec.com
Mon Dec 20 07:54:58 UTC 2021
-----Original Message-----
> Hi,
>
> Would you please leave a comment if you look at the patch?
Thanks for the patch, but sorry, currently at least I am not interested
in merging such a patch fixing minor coding style, typos in comments, and
etc. without fixing a bug, in order to avoid merging a lot of patches.
Thanks,
Kazu
> I won't take long.
>
> BR,
> Austin Kim
>
> 2021년 12월 14일 (화) 오전 10:38, Austin Kim <austindh.kim at gmail.com>님이 작성:
> >
> > fix minor spelling typos in symbols.c as below:
> >
> > useable => usable
> > higer => higher
> > versons => versions
> >
> > Signed-off-by: Austin Kim <austindh.kim at gmail.com>
> > ---
> > symbols.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/symbols.c b/symbols.c
> > index 73baa95..9ae0187 100644
> > --- a/symbols.c
> > +++ b/symbols.c
> > @@ -3139,7 +3139,7 @@ kallsyms_module_function_size(struct syment *sp, struct load_module *lm, ulong *
> > if (!(lm->mod_flags & MOD_KALLSYMS) || !(kt->flags & KALLSYMS_V2))
> > return FALSE;
> >
> > - if (THIS_KERNEL_VERSION >= LINUX(5,0,0)) /* st_size not useable */
> > + if (THIS_KERNEL_VERSION >= LINUX(5,0,0)) /* st_size not usable */
> > return FALSE;
> >
> > module_buf = GETBUF(lm->mod_size);
> > @@ -7624,7 +7624,7 @@ is_percpu_symbol(struct syment *sp)
> > * args[0] is checked to see whether it's the name of a variable, structure,
> > * union, or typedef. If so, args[0] is changed to the appropriate command,
> > * i.e., "p", "struct", "union", or "whatis", and the original args are all
> > - * shifted into the next higer args[] location.
> > + * shifted into the next higher args[] location.
> > */
> > int
> > is_datatype_command(void)
> > @@ -11608,7 +11608,7 @@ calculate_load_order_v2(struct load_module *lm, bfd *bfd, int dynamic,
> > }
> >
> > /*
> > - * Later versons of insmod store basic address information of each
> > + * Later versions of insmod store basic address information of each
> > * module in a format that looks like the following example of the
> > * nfsd module:
> > *
> > --
> > 2.20.1
> >
>
>
> --
> Crash-utility mailing list
> Crash-utility at redhat.com
> https://listman.redhat.com/mailman/listinfo/crash-utility
More information about the Crash-utility
mailing list