[dm-devel] linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689: bad if test ?

[Mike Snitzer]

On Mon, Jul 27 2015 at  3:00P -0400,
David Binderman <dcb314 at hotmail.com> wrote:

> Hello there,
> 
> [linux-4.2-rc4/drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction always evaluates to false: !EXPR && EXPR.
> 
> Source code is
> 
>   if (!mq->cache_hit_bits && mq->cache_hit_bits) {
> 
> Maybe
> 
>   if (!mq->cache_hit_bits) {
> 
> was intended.

Thanks, was fixed with this, will go upstream for 4.2-rc5:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=134bf30c06f057d6b8d90132e8f8b3cd2be79572