[dm-devel] [PATCH 2/4] dm stats: support precise timestamps

Bryn M. Reeves bmr at redhat.com
Mon Jul 27 15:11:09 UTC 2015


On Tue, Jun 09, 2015 at 05:21:39PM -0400, Mikulas Patocka wrote:
>  	/*
>  	 * Input format:
> -	 *   <range> <step> [<program_id> [<aux_data>]]
> +	 *   <range> <step> [<extra_parameters> <parameters>] [<program_id> [<aux_data>]]
>  	 */

Rather than adding optional parameters would it make sense to add a new
create method? E.g. "@stats_create_precise".

In some ways this is easier to deal with in userspace and there's alrady
a precedent for it with @stats_print vs. @stats_print_clear.

It's not a huge deal either way though - just simplifies formatting of
the messages a little.

Regards,
Bryn.




More information about the dm-devel mailing list